Skip to content

Ensure liveQueryCollections are not ready until all it's source collections are ready #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Ensure liveQueryCollections are not ready until all it's source collections are ready #390

wants to merge 6 commits into from

Conversation

samwillis
Copy link
Collaborator

@samwillis samwillis commented Aug 10, 2025 •
edited
Loading

replaces #384, fixes #383, fixes #370

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 95df0cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@tanstack/svelte-db Patch
@tanstack/react-db Patch
@tanstack/solid-db Patch
@tanstack/vue-db Patch
@tanstack/db Patch
@tanstack/electric-db-collection Patch
@tanstack/query-db-collection Patch
@tanstack/trailbase-db-collection Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 10, 2025 •
edited
Loading

More templates

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@390

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@390

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@390

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@390

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@390

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@390

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@390

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@390

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@390

commit: 95df0cd

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 10, 2025 •
edited
Loading

Size Change: +36 B (+0.06%)

Total Size: 58.5 kB

Filename Size Change
./packages/db/dist/esm/collection.js 9.87 kB +21 B (+0.21%)
./packages/db/dist/esm/query/live-query-collection.js 2.46 kB +15 B (+0.61%)
ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/change-events.js 1.13 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 2.98 kB
./packages/db/dist/esm/index.js 1.51 kB
./packages/db/dist/esm/indexes/auto-index.js 689 B
./packages/db/dist/esm/indexes/base-index.js 605 B
./packages/db/dist/esm/indexes/btree-index.js 1.47 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.03 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 4.19 kB
./packages/db/dist/esm/query/builder/functions.js 575 B
./packages/db/dist/esm/query/builder/index.js 3.79 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 890 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.48 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.03 kB
./packages/db/dist/esm/query/compiler/index.js 1.74 kB
./packages/db/dist/esm/query/compiler/joins.js 1.56 kB
./packages/db/dist/esm/query/compiler/order-by.js 677 B
./packages/db/dist/esm/query/compiler/select.js 655 B
./packages/db/dist/esm/query/ir.js 318 B
./packages/db/dist/esm/query/optimizer.js 2.44 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 2.29 kB
./packages/db/dist/esm/utils.js 419 B
./packages/db/dist/esm/utils/btree.js 5.93 kB
./packages/db/dist/esm/utils/comparison.js 718 B
./packages/db/dist/esm/utils/index-optimization.js 1.62 kB

compressed-size-action::db-package-size

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 10, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 1.05 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 902 B

compressed-size-action::react-db-package-size

@samwillis samwillis force-pushed the samwillis/fix-ready branch from 0f28a47 to 967f9e0 Compare August 10, 2025 16:54
This was referenced Aug 10, 2025
Closed
Open
@samwillis samwillis marked this pull request as ready for review August 10, 2025 17:10
@samwillis samwillis requested a review from kevin-dp August 10, 2025 17:10
This was referenced Aug 10, 2025
Open
Open
kevin-dp
kevin-dp approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@kevin-dp kevin-dp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left one nitpick.

packages/db/src/query/live-query-collection.ts
@@ -163,6 +163,12 @@ export function liveQueryCollectionOptions<
const collections = extractCollectionsFromQuery(query)

const allCollectionsReady = () => {
return Object.values(collections).every(
(collection) => collection.status === `ready`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collection's have a method that checks exactly this: collection.isReady(). Better to use that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-dp kevin-dp kevin-dp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samwillis @kevin-dp @tomkuehl